Toluene methylation with methanol was investigated on MFI-type zeolite catalysts containing Fe or Zn within the range of 0-2% by weight as an active component. The catalytic performances were compared on catalysts to which Fe or Zn was introduced by different methods, i.e., ion-exchanged and incorporation methods. The prepared catalysts were characterized by XRD, XRF, BET, FTIR and pyridine adsorption technique on in-situ FTIR. The results showed that the incorporated samples, H-Fe, Al-silicate (Si/Fe=150) and H-Zn, Al-silicate (Si/Zn=150), exhibited catalytic activity and xylene selectivities approximately equivalent to those from the ion-exchanged samples, Fe(0.8)/H-MFI and Zn(1.0)/H-MFI, containing nearly the same amount of Fe or Zn. The higher p-xylene selectivity was achieved with H-Fe, Al-silicate (Si/Fe=150) and H-Zn, Al-silicate (Si/Zn=150) because of Bronsted acid strengths weaker than Fe(0.8)/H-MFI and Zn(1.0)/H-MFI. Therefore, the isomerization of p-isomer produced primarily was suppressed on the incorporated catalysts better than the ion-exchanged ones.